Move schema_filter option to the correct place
#8585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the comment, as the option works the opposite of what is described here
javiereguiluz
approved these changes
Nov 3, 2017
There was a problem hiding this comment.
In the DoctrineMigrationsBundle doc we say the same about schema_filter. See https://symfony.com/doc/master/bundles/DoctrineMigrationsBundle/index.html#manual-tables
I've asked on Symfony Slack and some people have confirmed that our docs are wrong and @mcfedr is right about this change. Thanks!
PS: the related Doctrine code is here: https://github.com/doctrine/dbal/blob/4f7c1b7231e64e1c0b3ed39136120f9e9bb246fb/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php#L233-L247
|
Thanks for fixing the docs, Fred! I've merged this in the 2.7 version of the docs (that's why it appears to be closed) and will merge it up to the newer versions from there. |
wouterj
added a commit
that referenced
this pull request
Nov 12, 2017
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #8585). Discussion ---------- Move `schema_filter` option to the correct place Also change the comment, as the option works the opposite of what is described here Commits ------- 7c76a4b Move `schema_filter` option to the correct place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the comment, as the option works the opposite of what is described here